Skip to content

added module 10xbamtofastq#5671

Merged
BlueBicycleBlog merged 6 commits intomasterfrom
10xbamtofastq
May 22, 2024
Merged

added module 10xbamtofastq#5671
BlueBicycleBlog merged 6 commits intomasterfrom
10xbamtofastq

Conversation

@BlueBicycleBlog
Copy link
Copy Markdown
Contributor

@BlueBicycleBlog BlueBicycleBlog commented May 22, 2024

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • [x ] If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • [x ] Remove all TODO statements.
  • [x ] Emit the versions.yml file.
  • [x ] Follow the naming conventions.
  • [x ] Follow the parameters requirements.
  • [x ] Follow the input/output options guidelines.
  • Add a resource label
  • [x ] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

There is a syntax issue.

@BlueBicycleBlog BlueBicycleBlog requested review from a team and leoisl and removed request for a team May 22, 2024 19:21
Comment thread modules/nf-core/10xbamtofastq/main.nf Outdated
Copy link
Copy Markdown
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@BlueBicycleBlog BlueBicycleBlog added this pull request to the merge queue May 22, 2024
Merged via the queue into master with commit 63d6994 May 22, 2024
tstoeriko pushed a commit to tstoeriko/nf-core-modules that referenced this pull request May 23, 2024
* added module 10xbamtofastq

* remove extra test file

* Update main.nf.test

* Update main.nf

* Rename module and fix tests

---------

Co-authored-by: Harshil Patel <drpatelhh@gmail.com>
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
@SPPearce SPPearce deleted the 10xbamtofastq branch March 10, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants