Skip to content

Added nf-test for gatk4/intervallisttools#5672

Merged
SPPearce merged 7 commits intomasterfrom
feat_add_nf-test_gatk4/intervallisttools
May 22, 2024
Merged

Added nf-test for gatk4/intervallisttools#5672
SPPearce merged 7 commits intomasterfrom
feat_add_nf-test_gatk4/intervallisttools

Conversation

@KamilMaliszArdigen
Copy link
Copy Markdown
Contributor

Added nf-test for gatk4/intervallisttools

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@KamilMaliszArdigen KamilMaliszArdigen requested review from a team, kpadm and maxulysse and removed request for a team May 22, 2024 19:30
Copy link
Copy Markdown
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a stub test please (e.g. copy the test you have but add options "-stub"). That is assuming the module has a stub, if it doesn't then can you add the stub to the module itself too.

Comment thread modules/nf-core/gatk4/intervallisttools/tests/main.nf.test Outdated
@KamilMaliszArdigen
Copy link
Copy Markdown
Contributor Author

@SPPearce Added stub test as requested :)

@SPPearce SPPearce enabled auto-merge May 22, 2024 20:19
@SPPearce SPPearce added this pull request to the merge queue May 22, 2024
Merged via the queue into master with commit afb6046 May 22, 2024
@SPPearce SPPearce deleted the feat_add_nf-test_gatk4/intervallisttools branch May 22, 2024 20:37
tstoeriko pushed a commit to tstoeriko/nf-core-modules that referenced this pull request May 23, 2024
* Added nf-test for gatk4/intervallisttools

* Update modules/nf-core/gatk4/intervallisttools/tests/main.nf.test

Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>

* Added nf-test stub for gatk4/intervallisttools

* Updated snap nf-test stub for gatk4/intervallisttools

---------

Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants