Skip to content

Conversation

@prototaxites
Copy link
Contributor

@prototaxites prototaxites commented Nov 28, 2024

Since the module was created, Pyrodigal has received a --jobs flag to split the computation across threads - the Pyrodigal version has already been updated to support this but the module script is missing the option.

Edit: also bump Pyrodigal version

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@jasmezz
Copy link
Contributor

jasmezz commented Nov 29, 2024

Once this PR with a pyrodigal version update is merged, we can update the nf-core module, either here or in a separate PR.

@prototaxites
Copy link
Contributor Author

Sorted ✔️

@prototaxites prototaxites changed the title Pyrodigal - add --jobs flag for multi-threaded operation Pyrodigal - add --jobs flag for multi-threaded operation, bump version Nov 29, 2024
Copy link
Contributor

@jasmezz jasmezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including the version update as well. LGTM!

Co-authored-by: Jasmin Frangenberg <73216762+jasmezz@users.noreply.github.com>
@prototaxites prototaxites added this pull request to the merge queue Dec 5, 2024
Merged via the queue into nf-core:master with commit 938e803 Dec 5, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants