Skip to content

simplify assertion for stable files in a folder#7462

Closed
maxulysse wants to merge 3 commits into
nf-core:masterfrom
maxulysse:simplify_assertion
Closed

simplify assertion for stable files in a folder#7462
maxulysse wants to merge 3 commits into
nf-core:masterfrom
maxulysse:simplify_assertion

Conversation

@maxulysse
Copy link
Copy Markdown
Member

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Copy link
Copy Markdown
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

"genome.fasta:md5,6e9fe4042a72f2345f644f239272b7e6",
"seqid2taxid.map:md5,fe738f2333d57dde0db32239c04a93b8",
"taxDB:md5,37ea954363803b13c2c9f6ae36fc81c7"
"taxDB:md5,f9969245ac82fa42682289f5b0b6c67a"
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, so I'm concerned that taxDB is actually not stable

[
"database-build.log",
"database.report.tsv",
"library",
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rescued library as a folder name

"names.dmp",
"nodes.dmp",
"taxdump.tar.gz",
"taxonomy",
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and taxonomy

Comment thread modules/nf-core/catpack/prepare/tests/main.nf.test Outdated
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
@maxulysse maxulysse marked this pull request as draft February 11, 2025 16:04
@maxulysse
Copy link
Copy Markdown
Member Author

Please let's not merge this, I'll try to fix this properly within nft-utils.

My endgoal is something like:

    then {
      def unstableNames = ["stable_name_infolder.txt", "stable_name_in_subfolder.txt"]
      def stableFiles = getAllFilesFromChannel(process.out.folder[0][1], ignore: unstableNames)
      def stableNames = getAllFilesFromChannel(process.out.folder[0][1], includeDir: true, include: unstableNames)

      assertAll(
        { assert process.success },
        { assert snapshot(
            stableFiles,
            stableNames
          ).match()
        }
      )
    }

@maxulysse
Copy link
Copy Markdown
Member Author

Still a WIP, as I need to finish the function in nft-utils for this to work as expected

@jfy133
Copy link
Copy Markdown
Member

jfy133 commented Mar 26, 2025

Note the 'grep' exampledoesn't work, I'm reverting nf-core/website#3281

@SPPearce
Copy link
Copy Markdown
Contributor

@maxulysse , do you want to take another look at this now?

@SPPearce
Copy link
Copy Markdown
Contributor

SPPearce commented Mar 3, 2026

@maxulysse , is this still useful?

@maxulysse
Copy link
Copy Markdown
Member Author

Let's ditch that, and I'll work on it again from scratch

@maxulysse maxulysse closed this Mar 3, 2026
@github-project-automation github-project-automation Bot moved this from In progress to Closed in 2025 spring cleaning - modules (PRs) Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

6 participants