simplify assertion for stable files in a folder#7462
Closed
maxulysse wants to merge 3 commits into
Closed
Conversation
maxulysse
commented
Feb 10, 2025
| "genome.fasta:md5,6e9fe4042a72f2345f644f239272b7e6", | ||
| "seqid2taxid.map:md5,fe738f2333d57dde0db32239c04a93b8", | ||
| "taxDB:md5,37ea954363803b13c2c9f6ae36fc81c7" | ||
| "taxDB:md5,f9969245ac82fa42682289f5b0b6c67a" |
Member
Author
There was a problem hiding this comment.
ok, so I'm concerned that taxDB is actually not stable
maxulysse
commented
Feb 10, 2025
| [ | ||
| "database-build.log", | ||
| "database.report.tsv", | ||
| "library", |
Member
Author
There was a problem hiding this comment.
I rescued library as a folder name
maxulysse
commented
Feb 10, 2025
| "names.dmp", | ||
| "nodes.dmp", | ||
| "taxdump.tar.gz", | ||
| "taxonomy", |
mashehu
reviewed
Feb 11, 2025
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Member
Author
|
Please let's not merge this, I'll try to fix this properly within nft-utils. My endgoal is something like: |
Member
Author
|
Still a WIP, as I need to finish the function in nft-utils for this to work as expected |
Member
|
Note the 'grep' exampledoesn't work, I'm reverting nf-core/website#3281 |
Contributor
|
@maxulysse , do you want to take another look at this now? |
Contributor
|
@maxulysse , is this still useful? |
Member
Author
|
Let's ditch that, and I'll work on it again from scratch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #XXX
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda