Update mitohifi container and switch to nf-test#7770
Merged
SPPearce merged 11 commits intonf-core:masterfrom Mar 11, 2025
Merged
Update mitohifi container and switch to nf-test#7770SPPearce merged 11 commits intonf-core:masterfrom
SPPearce merged 11 commits intonf-core:masterfrom
Conversation
This was
linked to
issues
Mar 11, 2025
Contributor
Author
|
Getting the below linting errors. Not sure if need to be fixed or can be ignored - discussion on Slack suggests the latter maybe? https://nfcore.slack.com/archives/CE6PELWR4/p1725867108827219 |
Contributor
Author
|
Looks like the version number internally to mitohifi has not been bumped with the new release - have switched out to use a fixed version number for now. |
SPPearce
requested changes
Mar 11, 2025
Contributor
SPPearce
left a comment
There was a problem hiding this comment.
Can you add stubs and stub tests please.
SPPearce
reviewed
Mar 11, 2025
Contributor
Author
|
Done - looks like it's ready to go unless anything else needs changed? |
SPPearce
approved these changes
Mar 11, 2025
Contributor
SPPearce
left a comment
There was a problem hiding this comment.
Yes, looks good to me, thanks for adding nf-test and the snapshots :)
famosab
pushed a commit
to famosab/modules
that referenced
this pull request
Jun 3, 2025
* Update container * Update container * Update mitohifi container version and switch to nf-test * Fix tests and linting * Add mitohifi to conda skip json * Fix version number * Add stub tests and fix stub
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates mitohifi container to new build without conda defaults channel. Bump to nf-test because why not :)
PR checklist
Closes #XXX
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda