Skip to content

Conversation

@delagoya
Copy link
Contributor

Updated STAR version within the RSEM module to account for a aarch64 binary from bioconda.

PR checklist

Closes #8108

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile conda

@delagoya
Copy link
Contributor Author

Actually hold off on merging this - there may be conflicts with STAR genomes index from igenomes that was not picked up in small test profile.

@famosab
Copy link
Contributor

famosab commented Apr 30, 2025

@delagoya Any news on the conflicts? Is there test data that could reflect this? :)

@delagoya
Copy link
Contributor Author

delagoya commented May 1, 2025

I did a run on an AWS Graviton4 instance with the test_full profile and the pipeline completed successfully.

@delagoya
Copy link
Contributor Author

delagoya commented May 1, 2025

Note that I had to build a new reference for this to work using the recommended option from the docs. Using iGenomes fastq and annotation did produce errors

@delagoya
Copy link
Contributor Author

delagoya commented May 1, 2025

In other words, I would make a dependency on this merge to update the genome indexes away from iGenomes, which I believe is on the to-do list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update module: rsem/calculateexpression and rsem/preparereference

2 participants