-
Notifications
You must be signed in to change notification settings - Fork 953
add ctatsplicing/prepgenomelib and ctatsplicing/startocancerintrons #8144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
atrigila
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on migrating these modules to nf-core modules! Left a few suggestions for small details. I am also tagging the author of these local modules, @nvnieuwk , so that he can give a final look in case I am missing something. There is an open PR here: #8107 which is adding the STARFUSION process, which could come very useful to add the non-stub test.
nvnieuwk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM
PR checklist
Closes rnafusion#628
The reason I am only doing stub tests only is for practicality. The smallest reference i could get was about half a Gb, even when starting with the minigenome.fa and minigenome.gtf suggested by the tool's maintainers. I also considered adding starfusion/build so that i wouldn't have to store the reference on test-datasets, however this takes almost an hour to run on my system.
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda