-
Notifications
You must be signed in to change notification settings - Fork 950
fix: nf-test in strelka #8241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: nf-test in strelka #8241
Conversation
SPPearce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally good, assuming conda works when rerun
|
@SPPearce Maybe we can remove conda support for now and add it back in if strelka starts supporting python3? |
Hmmm, strelka is used in sarek, I don't think that sounds like a good idea. |
|
@maxulysse Any ideas on this? |
what was the error? |
|
OK, I have seen it this is BAD. |
|
Seems to be a known issue with conda: Illumina/strelka#199 |
Packages installed in the container on quay.io |
* update strelka tests * update snaps * Apply suggestions from code review * try fixing python to python2 * fix to 2.7.15 * language server * try adding htslib * update germline for language server and new test guidelines * fix to strelka version of container --------- Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
* update strelka tests * update snaps * Apply suggestions from code review * try fixing python to python2 * fix to 2.7.15 * language server * try adding htslib * update germline for language server and new test guidelines * fix to strelka version of container --------- Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
PR checklist
Closes #8031
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda