-
Notifications
You must be signed in to change notification settings - Fork 950
srst2/srst2 to nf-test #8301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
srst2/srst2 to nf-test #8301
Conversation
SPPearce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like meta.db should probably be a value channel.
The pileup file seems to be unstable too.
│ htsjdk.samtools.SAMException: Sequence name '347__lmr(B)__lmr(B)__00005' doesn't match regex: '[0-9A-Za-z!#$%&+./:;?@^_|~-][0-9A-Za-z!#$%&*+./:;=?@^_|~-]*' │
│ htsjdk.samtools.SAMException: Sequence name '347__lmr(B)__lmr(B)__00005' doesn't match regex: '[0-9A-Za-z!#$%&+./:;?@^_|~-][0-9A-Za-z!#$%&*+./:;=?@^_|~-]*' |
|
@jvhagey Do you think we can remove the bacteroides fragilis test? Becaus ethat one seems to cause the samtools errors. |
I'd say just remove it if we can't figure it out, yes. |
|
I decided to comment the tests out for now. There are a couple of instabel things even with the working test data. But for the sake of getting this finished up I would vote for merging this soon. And if the module ever gets updated (unlikely as the tool has not been changed since 2016) this can be tackeld again! |
* srst2/srst2 to nf-test * samtools error :( * update * move db to val input channel --------- Co-authored-by: Maxime U Garcia <max.u.garcia@gmail.com>
PR checklist
Closes #7700
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda