-
Notifications
You must be signed in to change notification settings - Fork 950
Migrate khmer/normalizebymedian to nf-test
#8357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SPPearce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel we should change the module here to use prefix.
This module apparently hasn't changed since the mass repo reorganisation almost 2.5 years ago.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect the tests could just use the basic fastq files too, rather than requiring SEQTK_MERGEPE first (but provided they work I guess they are fine)
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
|
Ok, I think it wants interleaved fastq files for paired ends, where read1 and read2 come next to each other in one file. |
* Migrate to nf-test * Update script * Update meta * Update modules/nf-core/khmer/normalizebymedian/main.nf Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com> * Update modules/nf-core/khmer/normalizebymedian/main.nf Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com> --------- Co-authored-by: LouisLeNezet <louislenezet@gmaio.com> Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
* Migrate to nf-test * Update script * Update meta * Update modules/nf-core/khmer/normalizebymedian/main.nf Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com> * Update modules/nf-core/khmer/normalizebymedian/main.nf Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com> --------- Co-authored-by: LouisLeNezet <louislenezet@gmaio.com> Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
PR checklist
Closes #7603
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda