Merged
Conversation
jfy133
approved these changes
Aug 22, 2025
Member
jfy133
left a comment
jfy133
left a comment
There was a problem hiding this comment.
Minor quibbles but otherwise looks good!
| type: file | ||
| description: HLA Class I 2-digit genotype results | ||
| pattern: "*ClassI-class.HLAgenotype2digits" | ||
| ontologies: [] |
Member
There was a problem hiding this comment.
I guess this is just a text file? Or is it a TSV file?
Contributor
Author
There was a problem hiding this comment.
tsv-ish file, but it doesn't end on tsv and the header starts with #
#Locus Allele 1 Confidence Allele 2 Confidence
A no NA hoz("A*24") NA
B no NA hoz("B*35") NA
C no NA hoz("C*17") NA
| description: HLA Class I non-classical 2-digit genotype results | ||
| pattern: "*ClassI-nonclass.HLAgenotype2digits" | ||
| ontologies: [] | ||
| ambiguity: |
Member
There was a problem hiding this comment.
Why is this in a different order that the module?
Contributor
Author
There was a problem hiding this comment.
because I couldn't be bothered to rearrange everything again
cavenel
pushed a commit
to cavenel/modules
that referenced
this pull request
Feb 5, 2026
* add seq2hla * circumvent empty checksums
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the seq2HLA module to call hlatypes from RNA sequencing data
PR checklist
Closes #XXX
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda