Skip to content

Update WHATSHAP/PHASE container, topic versions and task.cpus #9642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eliottBo merged 4 commits into from
Jan 13, 2026
Merged

Update WHATSHAP/PHASE container, topic versions and task.cpus #9642

eliottBo merged 4 commits into from
Jan 13, 2026

Conversation

@eliottBo
Copy link
Contributor

@eliottBo eliottBo commented Jan 13, 2026 •
edited
Loading

PR checklist

Closes #9641

  • This comment contains a description of changes (with reason).
  • Broadcast software version numbers to topic: versions - See version_topics
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

@eliottBo eliottBo self-assigned this Jan 13, 2026
@eliottBo eliottBo requested a review from HaidYi January 13, 2026 10:36
@mashehu
Copy link
Contributor

mashehu commented Jan 13, 2026

snapshots need to be updated, I guess

@eliottBo eliottBo mentioned this pull request Jan 13, 2026
Open
7 tasks
@eliottBo eliottBo added this pull request to the merge queue Jan 13, 2026
Merged via the queue into nf-core:master with commit 2356266 Jan 13, 2026
23 checks passed
@eliottBo eliottBo deleted the update-whatshap-phase branch January 13, 2026 14:57
vagkaratzas pushed a commit that referenced this pull request Jan 14, 2026
@eliottBo @vagkaratzas
Update WHATSHAP/PHASE container, topic versions and task.cpus (#9642)
912c6b7 
* Add task.cpus in bgzip command and https for container. Fixed the new way of getting the version with topics

* Add topics to meta

* Updateing snapshot to correctly assess versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SPPearce SPPearce SPPearce approved these changes

@HaidYi HaidYi Awaiting requested review from HaidYi

Assignees

@eliottBo eliottBo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

update module: WHATSHAP/PHASE

3 participants

@eliottBo @mashehu @SPPearce