Skip to content

Conversation

@vagkaratzas
Copy link
Contributor

@vagkaratzas vagkaratzas commented Jan 13, 2026

  1. Renamed subworkflow to be more nf-core compliant (won't break anything since it's not being used by any pipeline yet, and is being developed mainly as part of another subworkflow)
  2. Updated logic for skiping inputs and added an nf-test for it

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@vagkaratzas vagkaratzas added this pull request to the merge queue Jan 13, 2026
Merged via the queue into master with commit 662cffe Jan 13, 2026
32 checks passed
@vagkaratzas vagkaratzas deleted the update-fastq_generate_statistics branch January 13, 2026 11:50
vagkaratzas added a commit that referenced this pull request Jan 13, 2026
* fastq_qc_stats subworkflow update - renamed and testing for skip all inputs case

* bracket push
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants