Skip to content

Conversation

@jfy133
Copy link
Member

@jfy133 jfy133 commented Jan 14, 2026

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

jfy133 and others added 30 commits February 28, 2025 21:55
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
@jfy133 jfy133 enabled auto-merge January 14, 2026 13:07
@jfy133 jfy133 added this pull request to the merge queue Jan 14, 2026
Merged via the queue into master with commit 70c072e Jan 14, 2026
32 checks passed
@jfy133 jfy133 deleted the rgi-strict-syntax branch January 14, 2026 13:11
vagkaratzas pushed a commit that referenced this pull request Jan 14, 2026
* Add new input channel for premade seqid2map file

* Add extra tests for using custom seqid2map file

* Apply suggestions from code review

* Update modules/nf-core/kraken2/build/tests/main.nf.test

Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>

* Make RGI modules syntax compliant

---------

Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants