Conversation
54172ba to
70f1bc1
Compare
70f1bc1 to
aa9c564
Compare
|
|
||
| output: | ||
| tuple val(meta), path("hisat3n"), emit: index | ||
| tuple val("${task.process}"), val('hisat-3n'), eval("hisat-3n --version 2>&1 | grep -o 'version [^ ]*' | cut -d ' ' -f 2"), topic: versions, emit: versions_hisat3n_build |
There was a problem hiding this comment.
I suspect the version command could be shortened using sed to do both the grep and the cut
| tuple val("${task.process}"), val('hisat-3n'), eval("hisat-3n --version 2>&1 | grep -o 'version [^ ]*' | cut -d ' ' -f 2"), topic: versions, emit: versions_hisat3n_build | |
| tuple val("${task.process}"), val('hisat-3n'), eval("hisat-3n --version 2>&1 | grep -o 'version [^ ]*' | cut -d ' ' -f 2"), topic: versions, emit: versions_hisat3n |
There was a problem hiding this comment.
I'll be adding another module after this called hisat3n_align, which is why I was trying to differentiate -- given that context, does it still make sense to shorten the name?
There was a problem hiding this comment.
The emit versions_ is only used for testing actually, if nf-test was able to directly test the topic channel we wouldn't bother with it at all.
There was a problem hiding this comment.
All samtools tools use versions_samtools for instance
01e7dd9 to
35fce12
Compare
SPPearce
left a comment
There was a problem hiding this comment.
The linting is complaing about something with the command. I would try using single quotes in the eval (double quotes in the sed), and then it might be happier.
Other than that I'm happy to merge
SPPearce
left a comment
There was a problem hiding this comment.
You need to update your branch, unrelated changes are now failing.
* feat: hisat3n/build module * fix: try oras instead for singularity * fix: use sed instead of cut + grep * fix: simplify sed command to get around backslash error * test: update test snapshot
PR checklist
Closes #9667. Adds
hisat3n/build, a tool that builds a 3N-index (containing two hisat2 indexes), from a set of DNA sequences. Tests includes--base-changein nextflow.configext.args.topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda