Skip to content

Release v1.1.0#188

Merged
zachary-foster merged 79 commits into
masterfrom
dev
Feb 13, 2026
Merged

Release v1.1.0#188
zachary-foster merged 79 commits into
masterfrom
dev

Conversation

@zachary-foster
Copy link
Copy Markdown
Contributor

In progress

Zachary Foster and others added 30 commits June 27, 2025 13:47
Important! Template update for nf-core/tools v3.3.2
@zachary-foster zachary-foster marked this pull request as draft January 26, 2026 18:43
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 26, 2026

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit f9a0d73

+| ✅ 261 tests passed       |+
#| ❔   7 tests were ignored |#
!| ❗   1 tests had warnings |!
Details

❗ Test warnings:

  • included_configs - Pipeline config does not include custom configs. Please add the includeConfig line.

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.5.1
  • Run at 2026-02-13 21:36:48

@zachary-foster zachary-foster marked this pull request as ready for review January 28, 2026 23:14
Comment thread bin/subset_busco_gene.R
Comment thread bin/subset_core_gene.R Outdated
Comment thread conf/modules.config

// Settings to avoid API rate limits and not put too much stress on servers
maxForks = secrets.NCBI_API_KEY ? 8 : 3 // NCBI allows 3 requests/second without a key and 10 with
maxForks = params.max_parallel_downloads ?: (secrets.NCBI_API_KEY ? 9 : 1)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this duplication needed since you have the global definition in L243

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not sure I understand. I dont see a global definition on L243

Copy link
Copy Markdown

@jonasscheid jonasscheid Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I got confused with the lines. The question is: Can you harmonise the maxForks (maybe via label in base.config) to not repeat this line? Maybe even more worth to do labeling with your ressource configs in base.config (you are allowed to extend this)

EDIT: Nevermind seeing your comments below

Comment thread conf/modules.config
Comment thread conf/modules.config
Comment thread subworkflows/local/variant_analysis/main.nf
Comment thread tests/default.nf.test.snap
Comment thread workflows/pathogensurveillance.nf Outdated
Comment thread CHANGELOG.md Outdated
Comment thread README.md
Copy link
Copy Markdown

@jonasscheid jonasscheid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments are addressed in #194. Great stuff 👌🏻 After merging this it's ready to go from my side

1.1.0 release reviewer suggested changes
@nf-core-bot
Copy link
Copy Markdown
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.5.1.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@zachary-foster
Copy link
Copy Markdown
Contributor Author

Thanks!

Copy link
Copy Markdown
Contributor

@grunwald grunwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#189
Please address issue 189. Otherwise good to go.

@zachary-foster zachary-foster merged commit 13547ea into master Feb 13, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants