Release v1.1.0#188
Conversation
Important! Template update for nf-core/tools v3.3.2
|
1.1.0dev fix version issue
|
|
||
| // Settings to avoid API rate limits and not put too much stress on servers | ||
| maxForks = secrets.NCBI_API_KEY ? 8 : 3 // NCBI allows 3 requests/second without a key and 10 with | ||
| maxForks = params.max_parallel_downloads ?: (secrets.NCBI_API_KEY ? 9 : 1) |
There was a problem hiding this comment.
Is this duplication needed since you have the global definition in L243
There was a problem hiding this comment.
Im not sure I understand. I dont see a global definition on L243
There was a problem hiding this comment.
Sorry, I got confused with the lines. The question is: Can you harmonise the maxForks (maybe via label in base.config) to not repeat this line? Maybe even more worth to do labeling with your ressource configs in base.config (you are allowed to extend this)
EDIT: Nevermind seeing your comments below
jonasscheid
left a comment
There was a problem hiding this comment.
My comments are addressed in #194. Great stuff 👌🏻 After merging this it's ready to go from my side
1.1.0 release reviewer suggested changes
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.5.1. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
|
Thanks! |
Fix singularity container
In progress