Skip to content

second reviewer comments resolve#74

Merged
vagkaratzas merged 3 commits into
nf-core:devfrom
vagkaratzas:changes-second-review
Feb 9, 2026
Merged

second reviewer comments resolve#74
vagkaratzas merged 3 commits into
nf-core:devfrom
vagkaratzas:changes-second-review

Conversation

@vagkaratzas
Copy link
Copy Markdown
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/proteinannotator branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (e.g. nf-test test */local --profile=~test,docker for all new local tests).
  • Check for unexpected warnings in debug mode (nf-test test */local --profile=~test,docker,debug).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@vagkaratzas vagkaratzas requested a review from jfy133 February 9, 2026 09:55
@nf-core-bot
Copy link
Copy Markdown
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.5.1.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

Copy link
Copy Markdown
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for that one comment these address my comments!

@vagkaratzas
Copy link
Copy Markdown
Collaborator Author

Except for that one comment these address my comments!

Since it was non-blocking, I'll go ahead, and add this to future tasks :P

@vagkaratzas vagkaratzas merged commit bf1bee7 into nf-core:dev Feb 9, 2026
7 checks passed
@vagkaratzas vagkaratzas deleted the changes-second-review branch February 9, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants