Skip to content

Conversation

@milos7250
Copy link

@milos7250 milos7250 commented Mar 24, 2025

Hi all,

after the latest update to GFFREAD, they are using the id variable from the meta argument as the name of the output file. At the moment, the meta variable in this step is empty, therefore the resulting file has name null.gtf. This PR resolves this issue by specifying the basename of the input gff file as the id for this process.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nf-core-bot
Copy link
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.0.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@maxulysse
Copy link
Member

yes please

@pinin4fjords pinin4fjords changed the base branch from master to dev June 4, 2025 18:40
@pinin4fjords
Copy link
Member

Did it slightly differently in #1560, but added you to the creds. Closing this.

BTW- for future contribs could you raise against dev please? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants