Skip to content

Finish singleR implementation#200

Merged
nictru merged 50 commits intodevfrom
singleR
Jul 14, 2025
Merged

Finish singleR implementation#200
nictru merged 50 commits intodevfrom
singleR

Conversation

@nictru
Copy link
Copy Markdown
Collaborator

@nictru nictru commented Jul 13, 2025

This builds up on #187 but aligns the implementation more with the existing pipeline architecture and nf-core guidelines
The following changes have been made:

  • There is now an additional CSV input, where each row represents one celldex reference
  • There are tests for all the newly added processes and subworkflows
  • Generally updated workflow hierarchy

@addityea please have a look at the changes, and let me know if these still resemble your original idea.

addityea and others added 30 commits May 21, 2025 16:27
…for the celldex reference. There are downstream pipeline errors however.
celldex reference stored at the relative path:

`celldex_references/celldex_hpca__2024-02-26_h5_se``

The reference was copied from the results of a run with
profile test_full and should give identical results.

This works on Dardel for me, e.g. with this command:

```
module load PDC java singularity
export NXF_SINGULARITY_CACHEDIR="~/singularity_cache"

./nextflow run main.nf -profile pdc_kth,test_offline --project=naiss2024-22-1150 --outdir ./results
```
test_full profile.

Added:
- celldex_reference_label parameter with default value 'label.main'
- support for multiple references in CELLTYPES_SINGLER
- proper downloading of multiple references using CELLTYPES_CELLDEXDOWNLOAD
…bled singleR in case unsupported env methods like Conda/mamba is used;

removed unwanted lines and print statements from singleR
…ort for previously missing SingleCellExperiment; removed some unwanted/ commented lines
…ted meta.yml, removed container switch logic
Merging as tests have succeeded.
@nf-core-bot
Copy link
Copy Markdown
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.3.1.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 13, 2025

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 052b8cd

+| ✅ 273 tests passed       |+
!| ❗  20 tests had warnings |!
Details

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: conf/igenomes_ignored.config
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in nextflow.config: Optionally, you can add a pipeline-specific nf-core config at https://github.com/nf-core/configs
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in README.md: Add bibliography of tools and data used in your pipeline
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • local_component_structure - unify_genes.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - integrate.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - finalize.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - per_group.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - scimilarity.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - combine.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - unify.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure

✅ Tests passed:

Run details

  • nf-core/tools version 3.3.1
  • Run at 2025-07-14 08:05:51

@addityea
Copy link
Copy Markdown
Contributor

This builds up on #187 but aligns the implementation more with the existing pipeline architecture and nf-core guidelines The following changes have been made:

* There is now an additional CSV input, where each row represents one celldex reference

* There are tests for all the newly added processes and subworkflows

* Generally updated workflow hierarchy

@addityea please have a look at the changes, and let me know if these still resemble your original idea.

Hey @nictru , Yes, the implementation of singleR is still following the ideas we had! All good from my end! Thanks!

@nictru nictru marked this pull request as ready for review July 14, 2025 09:50
@nictru nictru merged commit 283f4ea into dev Jul 14, 2025
77 of 91 checks passed
@nictru nictru deleted the singleR branch July 14, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants