Add cell cycle scoring to QC subworkflow#266
Conversation
…ico adviced in nf-core#171 issue regarding sex prediction
| # Versions | ||
|
|
||
| versions = { | ||
| "${task.process}": {"python": platform.python_version(), "scanpy": sc.__version__} |
There was a problem hiding this comment.
You did not pin the python version in the conda env, this might break tests when running them via conda. You can either remove the python version from the version capturing, or pin it in the environment yml file
There was a problem hiding this comment.
I will fix it the same way as in the scanpy/pca module:
- conda-forge::python=3.12.11
Just put some emodzi and I will push these changes :)
nictru
left a comment
There was a problem hiding this comment.
Really good job overall!
|
@nictru I encountered with a small problem during test snapshot gathering; I was running nf-test with the following command Am I right, that in github tests the running carried out with |
When you specify the test you should run using the |
0483e27 to
4372914
Compare
Implements per-cell cell cycle scoring as a QC step, placing it after doublet detection within the
QUALITY_CONTROLsubworkflow. Scores are stored asobscolumns and merged into the final h5ad via the existingFINALIZE_QC_ANNDATASmechanism, making them available as covariates in downstream steps (e.g.--S_score,G2M_score).Implementation details
New module:
SCANPY_CELLCYCLEsc.tl.score_genes_cell_cycle()from Scanpy (Tirosh et al. 2015 gene sets, same as Seurat).pklofobscolumns (S_score,G2M_score,phase) that flows intoFINALIZE_QC_ANNDATASalongside cell type annotations — the module does not rewrite the main h5ad.h5adfor inspection during developmentvarcolumn rather than the indexGene lists as bundled assets
assets/cell_cycle_genes/, making them transparent, auditable, and version-controlled--s_genes/--g2m_genes(e.g. for rat or zebrafish homologs)--species(default:human); the pipeline resolves the correct asset files automaticallyParameters
--specieshumanhumanormouse--cell_cycle_scoringtrue--s_genes--g2m_genesUsage
Testing
modules/local/scanpy/cellcycle/tests/) cover human scoring and stub runsubworkflows/local/quality_control/tests/) updated with the 3 new inputs; a dedicated"Should run with cell cycle scoring"test added withcell_cycle_scoring = true--profile docker,testPR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).