Skip to content

Conversation

@rcannood
Copy link
Contributor

Accidentally closed #13.

Changes:

  • If fs.renameSync fails (e.g. because source and destination files are on different partitions), try fs.copySync and fs.unlinkSync instead (Add try catch to fs.renameSync #14).

…re on different partitions), try `fs.copySync` and `fs.unlinkSync` instead.
@rcannood
Copy link
Contributor Author

Apologies, I accidentally closed #13 because I didn't realise I had created the original PR from data-intuitive/setup-nextflow@master.

Do you have an example of it in use? Sorry, I forgot to kick off the tests, let's see if they all pass!

I created a repository with two github actions: one that uses maximize-build-space and then setup-nextflow, and then one that just runs setup-nextflow. I would also include a test that runs the GitHub action from this PR, but then I would need to create a release for it 🤓.

@emiller88 Is this an answer to your question?

edmundmiller added a commit that referenced this pull request Jun 23, 2023
Copy link
Collaborator

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, let's merge this, since I don't have write access to your repo. I wrote a quick CI check as well for it.

@edmundmiller edmundmiller merged commit b9495c9 into nf-core:master Jun 23, 2023
edmundmiller added a commit that referenced this pull request Jun 23, 2023
@MillironX
Copy link
Member

Wow! I go to the field for a month, and this place starts hopping! I'm sorry for leaving you to hold the bag, @emiller88.

Before I tag a new release version, I would like a better understanding of how this works. @rcannood, could you provide a link to a repo that requires this patch? I want to dig into the internals a bit more, especially since easimon/maximize-build-space explicitly states

This action is a hack, really (emphasis theirs)

@rcannood
Copy link
Contributor Author

rcannood commented Aug 1, 2023

Welcome back @MillironX !

Sorry for the late response, I've also been away on holidays.

This patch was required for running setup-nextflow after maximize-build-space.

name: Test

on:
  push:
  workflow_dispatch:

jobs:
  test:
    runs-on: ubuntu-latest
    steps:
      - uses: easimon/maximize-build-space@v7
      - uses: nf-core/setup-nextflow@v1.3.0

@MillironX
Copy link
Member

This patch was required for running setup-nextflow after maximize-build-space.

Ok. Do you have an example of a pipeline or module whose tests require maximize-build-space, though?

@rcannood
Copy link
Contributor Author

rcannood commented Aug 7, 2023

I originally encountered it when rendering the viash.io documentation using this github action. You can see I swapped out the actions/setup-nextflow@v1.2.0 because it wasn't working in combination with easimon/maximize-build-space@v6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants