Skip to content

fix: address review comments on PR #139 #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
heylf merged 1 commit into from
May 21, 2026
Merged

fix: address review comments on PR #139 #160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions workflows/spatialxe.nf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,12 +205,12 @@ workflow SPATIALXE {
error("❌ Xenium bundle does not exist: ${bundle}")
}

def missing_required = bundle_required_files.findAll { !file("${bundle_path}/${it}").exists() }
def missing_required = bundle_required_files.findAll { check -> !file("${bundle_path}/${check}").exists() }
if (missing_required) {
error("❌ Missing required file(s) in xenium bundle '${bundle}': ${missing_required}")
}

def missing_optional = bundle_optional_files.findAll { !file("${bundle_path}/${it}").exists() }
def missing_optional = bundle_optional_files.findAll { check -> !file("${bundle_path}/${check}").exists() }
if (missing_optional) {
log.warn("⚠️ Missing optional file(s) in xenium bundle '${bundle}': ${missing_optional}")
}
Expand Down
Loading