Skip to content

fix incorrect handling of Assertion failure for no_prompt mode#4232

Merged
mashehu merged 1 commit into
nf-core:devfrom
mashehu:fix-no-prompt-and-test-failure
Apr 28, 2026
Merged

fix incorrect handling of Assertion failure for no_prompt mode#4232
mashehu merged 1 commit into
nf-core:devfrom
mashehu:fix-no-prompt-and-test-failure

Conversation

@mashehu
Copy link
Copy Markdown
Contributor

@mashehu mashehu commented Apr 28, 2026

in no_prompt mode we never wrote to self.error, which caused nf-core m test -p to always be successful.

closes #4227

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.37%. Comparing base (e66ecde) to head (4744d36).
⚠️ Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/components/components_test.py 50.00% 3 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mashehu mashehu force-pushed the fix-no-prompt-and-test-failure branch from 59ee466 to 4744d36 Compare April 28, 2026 10:06
@mashehu mashehu merged commit 37394a9 into nf-core:dev Apr 28, 2026
118 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants