Skip to content

Remove format constraint for igenomes_base#4253

Merged
mashehu merged 4 commits intodevfrom
nvnieuwk-patch-1
Apr 30, 2026
Merged

Remove format constraint for igenomes_base#4253
mashehu merged 4 commits intodevfrom
nvnieuwk-patch-1

Conversation

@nvnieuwk
Copy link
Copy Markdown
Contributor

This pull request removes the format from igenomes base as this was causing some issues with the default s3 path on some infrastructures.

Validation on all paths derived from the igenomes base still happens fully so that also indirectly validates igenomes base when used

@nvnieuwk nvnieuwk changed the base branch from main to dev April 30, 2026 11:27
@github-actions
Copy link
Copy Markdown
Contributor

This PR is against the main branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @nvnieuwk,

It looks like this pull-request is has been made against the nf-core/tools main branch.
The main branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to main are only allowed if they come from the nf-core/tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.80%. Comparing base (9cf0b98) to head (cb85e5a).
⚠️ Report is 10 commits behind head on dev.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mashehu mashehu merged commit 59313e5 into dev Apr 30, 2026
195 of 207 checks passed
@mashehu mashehu deleted the nvnieuwk-patch-1 branch April 30, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants