added some clarifications/examples regarding port forwards of VPC tiers #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
=======================================
Coverage 84.40% 84.40%
=======================================
Files 53 53
Lines 5509 5509
Branches 1246 1246
=======================================
Hits 4650 4650
Misses 432 432
Partials 427 427
Continue to review full report at Codecov.
|
resmo
reviewed
Sep 18, 2020
plugins/modules/cs_portforward.py
Outdated
| network: | ||
| description: | ||
| - Name of the network. | ||
| - Name of the network/vpc tier. Required when forwarding the first port of an VPC tier. |
Member
There was a problem hiding this comment.
This is rather confusing, can we simplify to say "network is required if VPC when creating a rule"? If so, we could even fail in the code if this condition is not given.
Collaborator
Author
There was a problem hiding this comment.
The reality is that it is only required for the first port, but it actually does not matter.
It is just effortless to specify the network.
resmo
approved these changes
Sep 19, 2020
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address issue #35