Skip to content

Conversation

@md5
Copy link
Contributor

@md5 md5 commented Jan 28, 2015

This PR adds configuration for Travis CI.

The tests on my Travis setup are currently failing, but that's because getEndpoint is calling exists on /var/run/docker.sock and Docker isn't running in the Travis environment. I have a similar issue with that same test failing locally because I'm running boot2docker and my DOCKER_HOST is set to point to my b2d VM.

Travis would still need to be turned on for jwilder/docker-gen for this to work.

@datacoda
Copy link

I think you might be able to move the (3?) getEndpoint related tests into their own file with // +build !travis as a guard?

@md5
Copy link
Contributor Author

md5 commented Jan 28, 2015

I'd actually prefer getEndpoint to not call exists. It doesn't do any
similar checks on a tcp:// DOCKER_HOST.

jwilder added a commit that referenced this pull request Jan 28, 2015
Add Travis CI configuration
@jwilder jwilder merged commit 0e24cd2 into nginx-proxy:master Jan 28, 2015
@jwilder
Copy link
Collaborator

jwilder commented Jan 28, 2015

Cool. I've turned it on for jwilder/docker-gen. We can probably move the exist check out of the getEndpoint. It might not even be necessary since trying to open it will still fail and should already be handled.

@md5
Copy link
Contributor Author

md5 commented Jan 28, 2015

Yeah, I think if the exists check isn't there, then a connection to a missing Unix socket will fail at the same time as a bad TCP connection. That seems appropriate to me.

@md5 md5 deleted the add-travis-ci branch January 28, 2015 06:38
@md5
Copy link
Contributor Author

md5 commented Jan 28, 2015

I also just realized that I might have added the build status badge to README.md. The markdown looks like this

[![Build Status](https://travis-ci.org/jwilder/docker-gen.svg?branch=master)](https://travis-ci.org/jwilder/docker-gen)

@jwilder
Copy link
Collaborator

jwilder commented Jan 28, 2015

Added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants