Skip to content

Fix logrotate permissions - #1770

Merged
karensantana merged 6 commits into
mainfrom
fix-logrotate-permissions
Jul 15, 2026
Merged

Fix logrotate permissions#1770
karensantana merged 6 commits into
mainfrom
fix-logrotate-permissions

Conversation

@karensantana

Copy link
Copy Markdown
Contributor

Proposed changes

When logrotate runs (through systemd timer or manually), it ignores /etc/logrotate.d/nginx-agent because its permissions are 0664 (group-writable) instead of 0644. This PR fixes this behavior by setting the permissions of the logrotate config file to 644.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@karensantana
karensantana requested a review from a team as a code owner June 30, 2026 15:45
@github-actions github-actions Bot added bug Something isn't working dependencies labels Jun 30, 2026
@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.12%. Comparing base (29fdf22) to head (8c2af13).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1770      +/-   ##
==========================================
- Coverage   85.18%   85.12%   -0.06%     
==========================================
  Files         105      105              
  Lines       13759    13759              
==========================================
- Hits        11721    11713       -8     
- Misses       1514     1522       +8     
  Partials      524      524              

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29fdf22...8c2af13. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@karensantana
karensantana merged commit ab36e92 into main Jul 15, 2026
114 of 127 checks passed
@karensantana
karensantana deleted the fix-logrotate-permissions branch July 15, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants