Skip to content

Conversation

@nickchen
Copy link

Proposed changes

  • clean up, use generated enum instead of 0 int for proto type
  • check for non-empty report before sending, this should fix the empty report on the consumer side

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@nickchen nickchen requested review from Dean-Coakley, oliveromahony and sanathkumarbs and removed request for Dean-Coakley and oliveromahony October 19, 2022 15:18
@github-actions github-actions bot added the bug Something isn't working label Oct 19, 2022
@oliveromahony
Copy link
Contributor

@aphralG has a fix for this which prevents the calculation of the empty metrics reports instead of checking for empty data and discarding. Let's wait for that PR instead of merging this, thanks

@sanathkumarbs sanathkumarbs mentioned this pull request Oct 26, 2022
4 tasks
@sanathkumarbs
Copy link

Likely should close this as we have #82

@oliveromahony oliveromahony deleted the no-empty-metrics-report branch November 28, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants