Skip to content

Conversation

@aphralG
Copy link
Contributor

@aphralG aphralG commented Oct 21, 2022

Proposed changes

Setting defaults for advanced metrics flags caused empty metric reports to be sent.

  • Remove defaults from advanced metrics flags
  • Reduce log level of "Error getting default network interface"
  • Clean up comms.go
  • Check if report is empty before metrics report is sent

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@aphralG aphralG self-assigned this Oct 21, 2022
@github-actions github-actions bot added bug Something isn't working dependencies labels Oct 21, 2022
Copy link
Collaborator

@dhurley dhurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just have 2 minor comments

Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link

@sanathkumarbs sanathkumarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@sanathkumarbs
Copy link

Likely should close #79 as we this PR.

@aphralG aphralG merged commit 29a7d1d into main Nov 3, 2022
@oliveromahony oliveromahony deleted the fix-empty-metric-reports branch November 21, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants