Coverity issues.#1056
Merged
Merged
Conversation
This makes the ownership of the request pointer clearer for readers and avoids unnecessary confusion for static analyzers.
Found by Coverity (CID 1692699).
Native frames always have an associated function. Keep the function lookup in the native-frame branch to make the invariant explicit and to avoid confusing static analysis. Found by Coverity (CID 1681309).
Contributor
|
One question for commit 3: Is there a test case covering Error.stack output for bound functions? If not, adding one to the njs test suite would lock in the correct behavior and prevent regression. |
VadimZhestikov
approved these changes
May 14, 2026
Contributor
VadimZhestikov
left a comment
VadimZhestikov
left a comment
There was a problem hiding this comment.
2 minor notes, otherwise looks good
github-project-automation
Bot
moved this from New
to In Progress
in NGINX OSS Unified Workspace
Contributor
Author
https://github.com/nginx/njs/blob/master/src/test/njs_unit_test.c#L22264 covers this. |
github-project-automation
Bot
moved this from In Progress
to Done
in NGINX OSS Unified Workspace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.