Skip to content

QuickJS: fixed r.subrequest() to a location with JS handler. #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2025
Merged

QuickJS: fixed r.subrequest() to a location with JS handler. #977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d89585e
Version bump.
xeioex Oct 9, 2025
b6ea63d
QuickJS: fixed r.subrequest() to a location with JS handler.
xeioex Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions nginx/ngx_http_js_module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5843,17 +5843,11 @@ ngx_http_qjs_subrequest_done(ngx_http_request_t *r, void *data, ngx_int_t rc)

cx = ctx->engine->u.qjs.ctx;

if (!JS_IsObject(ngx_qjs_arg(sctx->args[0]))) {
reply = ngx_http_qjs_request_make(cx, NGX_QJS_CLASS_ID_HTTP_REQUEST, r);
if (JS_IsException(reply)) {
ngx_log_error(NGX_LOG_ERR, r->connection->log, 0,
"js subrequest reply creation failed");
return NGX_ERROR;
}


} else {
reply = JS_DupValue(cx, ngx_qjs_arg(sctx->args[0]));
reply = ngx_http_qjs_request_make(cx, NGX_QJS_CLASS_ID_HTTP_REQUEST, r);
if (JS_IsException(reply)) {
ngx_log_error(NGX_LOG_ERR, r->connection->log, 0,
"js subrequest reply creation failed");
return NGX_ERROR;
}

rc = ngx_qjs_call(cx, event->function, &reply, 1);
Expand Down
4 changes: 2 additions & 2 deletions src/njs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@

#include <njs_auto_config.h>

#define NJS_VERSION "0.9.3"
#define NJS_VERSION_NUMBER 0x000903
#define NJS_VERSION "0.9.4"
#define NJS_VERSION_NUMBER 0x000904


#include <string.h>
Expand Down