Skip to content

Conversation

@VadimZhestikov
Copy link
Contributor

No description provided.

@VadimZhestikov VadimZhestikov requested a review from xeioex October 23, 2025 21:29
@VadimZhestikov VadimZhestikov changed the title Add missed checks for errors in ngx_(js|qjs)_exception(). Move error logging into ngx_(js|qjs)_exception(). Oct 23, 2025
@VadimZhestikov VadimZhestikov changed the title Move error logging into ngx_(js|qjs)_exception(). Modules: added error handling when logging js exception string. Oct 23, 2025
xeioex
xeioex previously requested changes Oct 23, 2025
Copy link
Contributor

@xeioex xeioex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good.

Copy link
Contributor

@xeioex xeioex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xeioex
Copy link
Contributor

xeioex commented Oct 23, 2025

Modules: added error handling when logging js exception string.
->

Modules: added error handling when logging an exception string. the article is missing.

@VadimZhestikov VadimZhestikov changed the title Modules: added error handling when logging js exception string. Modules: add error handling when logging a js exception string. Oct 24, 2025
@VadimZhestikov VadimZhestikov requested a review from xeioex October 24, 2025 00:03
@VadimZhestikov VadimZhestikov changed the title Modules: add error handling when logging a js exception string. Modules: added error handling when logging a js exception string. Oct 24, 2025
@VadimZhestikov VadimZhestikov merged commit 47aa7ca into nginx:master Oct 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants