Respecting user provided CFLAGS.

[xeioex]

No description provided.

[BalkanMadman]

As far as I understand, the compiler warnings (not -Werror) are disabled when CFLAGS are set? I think warnings are generally a good thing and don't cause harm, so they should probably be always enabled (with the intent of users bugging upstream when those pop up).

I think a better approach is to have certain required CFLAGS, like -fPIC and the warnings and the default CFLAGS. The required CFLAGS should be always set (well, because they're required) and the default CFLAGS are set if the user doesn't set the CFLAGS environment variable. I'm also not sure how well it interplays with your --with-cc-opt configure option.

[BalkanMadman]

What I imagine is something like CFLAGS="${NJS_REQUIRED_CFLAGS} ${CFLAGS:-${NJS_DEFAULT_CFLAGS}}"