Fix Overlay Throwing Errors

[Lexer747]

Summary

As reported by #92 (but I personally didn't encounter until #87 was merged) when the HD bar is empty it will spam the logs with exceptions.

Looking at what causes this it's two things:

• When the bar is nearly empty:
  • Ratio can be negative depending on the settings
  • If the ratio is negative then negative pixels are requested for the sub image
• When the bar is actually empty:
  • progressFill is 0 which asks for a 0 width sub image

Therefore to make the code more robust ratio is always clamped between 0 and 1. And when progressFill is less than or equal to 1 we should just not draw the second image. (which was what was already happening if you think about because the exception is complaining it can't draw an image).

---

Aside: updated the copyright (git history) and formatting of the file.

Testing

A minute of gargoyle killing flicking through the settings showing the RL logs and the lack of spam :)

https://www.youtube.com/watch?v=WBdZh-M7X_c

[Lexer747]

@PedroSilvaAlves since you've worked in this area before please let me know if this makes sense to you also.

[ngraves95]

Should this check for < 1 instead of <= 1? progressFill == 1 seems like a valid config to render

[Lexer747]

Yeah that's probably more correct, my own comment even would indicate that 😅

[Lexer747]

@PedroSilvaAlves another ping, as I'd appreciate your input 😁

[PedroSilvaAlves]

Sorry for the delay, looks good to me, appreciate the fix. Thank you!