Feature: Option to force standard quality Attack Bar#87
Feature: Option to force standard quality Attack Bar#87Lexer747 merged 3 commits intongraves95:mainfrom
Conversation
|
Instead of just forcing low detail as an option, could it instead be a select: |
…(Auto/Standard/High Detail)
|
Hey, I've updated the PR based on the feedback. The Force Standard Quality toggle has been replaced with an Attack Bar Style dropdown. Style dropdown with three options:
Default is Auto, so existing behavior is unchanged. Tested in-game and all three options work as expected. |
|
Testing looks great! I'll do a code review this week, thank you for working on this. |
|
I'm getting two different exceptions while testing this: And With these settings Both are thrown on line 107 of Ah I just checked and this is happening on Will review the code in this PR now. |
Lexer747
left a comment
Lexer747
left a comment
There was a problem hiding this comment.
Nice thanks for adding the option :)
## Summary As reported by #92 (but I personally didn't encounter until #87 was merged) when the HD bar is empty it will spam the logs with exceptions. Looking at what causes this it's two things: * When the bar is nearly empty: * Ratio can be negative depending on the settings * If the ratio is negative then negative pixels are requested for the sub image * When the bar is actually empty: * `progressFill` is `0` which asks for a 0 width sub image Therefore to make the code more robust `ratio` is always clamped between `0` and `1`. And when `progressFill` is less than or equal to `1` we should just not draw the second image. (which was what was already happening if you think about because the exception is complaining it can't draw an image). ----- Aside: updated the copyright (git history) and formatting of the file. ## Testing A minute of gargoyle killing flicking through the settings showing the RL logs and the lack of spam :) https://www.youtube.com/watch?v=WBdZh-M7X_c
3 participants
Option to force standard quality Attack Bar regardless of option selected by Interface Styles
Raised in Issue #85