-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Refactor docs from store.pipe(select(...)) to store.select(...) #2710
Copy link
Copy link
Closed
Labels
Comp: DocsGood First IssueGood issue for first-time contributorGood issue for first-time contributorhelp wanted
Description
I'm suggesting to use store.select as the recommended way to select from the Store.
This question is frequently asked - which way to use, and if I'm recommending store.select then why the docs have it otherwise?
The reasons why I suggest store.select are:
- it's easier to mock for tests with a simple mock object
- it's shorter to write
- having a pipe
selectencourages further addition of other operators. That logic might be better handled in selector itself.
store.select was initially deprecated, and then un-deprecated - see some history here: #1361 (comment)
Other information:
I would be willing to submit a PR for the docs ❤️
[ ] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Comp: DocsGood First IssueGood issue for first-time contributorGood issue for first-time contributorhelp wanted