Skip to content

Conversation

@desmondblue
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #4740

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[X ] No

Other information

@netlify
Copy link

netlify bot commented Mar 27, 2025

Deploy Preview for ngrx-io ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2e83ee8
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/67e514e8b6de6c0008003954
😎 Deploy Preview https://deploy-preview-4741--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @desmondblue !

@timdeschryver timdeschryver merged commit 8e52f1b into ngrx:main Mar 28, 2025
10 checks passed
@desmondblue
Copy link
Contributor Author

@timdeschryver No thanks needed this is the bare minimum I could do😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@ngrx/eslint-plugin no-dispatch-in-effects documentation is incorrect

3 participants