Skip to content

fix(store): cleanup observers once subjects complete#2401

Merged
arturovt merged 2 commits into
masterfrom
fix/store-unsubscribe
Mar 20, 2026
Merged

fix(store): cleanup observers once subjects complete#2401
arturovt merged 2 commits into
masterfrom
fix/store-unsubscribe

Conversation

@arturovt
Copy link
Copy Markdown
Member

Using the same approach implemented in Angular's QueryList.

Using the same approach implemented in Angular's `QueryList`.
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Mar 20, 2026

View your CI Pipeline Execution ↗ for commit 42aba20

Command Status Duration Result
nx run-many --target=test --all --configuration... ✅ Succeeded 2m 18s View ↗
nx run-many --target=lint --all --exclude=creat... ✅ Succeeded 1s View ↗
nx lint-types store ✅ Succeeded <1s View ↗
nx run-many --target=build --all ✅ Succeeded 1m 35s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-20 21:10:35 UTC

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Mar 20, 2026

Open in StackBlitz

@ngxs/devtools-plugin

npm i https://pkg.pr.new/@ngxs/devtools-plugin@2401

@ngxs/form-plugin

npm i https://pkg.pr.new/@ngxs/form-plugin@2401

@ngxs/hmr-plugin

npm i https://pkg.pr.new/@ngxs/hmr-plugin@2401

@ngxs/router-plugin

npm i https://pkg.pr.new/@ngxs/router-plugin@2401

@ngxs/storage-plugin

npm i https://pkg.pr.new/@ngxs/storage-plugin@2401

@ngxs/store

npm i https://pkg.pr.new/@ngxs/store@2401

@ngxs/websocket-plugin

npm i https://pkg.pr.new/@ngxs/websocket-plugin@2401

commit: 42aba20

@bundlemon
Copy link
Copy Markdown

bundlemon Bot commented Mar 20, 2026

BundleMon

Files updated (2)
Status Path Size Limits
fesm2022/ngxs-store.mjs
109.21KB (+133B +0.12%) 110KB / +0.5%
fesm2022/ngxs-store-internals.mjs
13.74KB (+114B +0.82%) 15KB / +0.5%
Unchanged files (4)
Status Path Size Limits
fesm2022/ngxs-store-internals-testing.mjs
10.32KB 13KB / +0.5%
fesm2022/ngxs-store-operators.mjs
6.05KB 7KB / +0.5%
fesm2022/ngxs-store-plugins.mjs
2.37KB 3KB / +0.5%
fesm2022/ngxs-store-experimental.mjs
574B 2KB / +0.5%

Total files change +247B +0.17%

Groups updated (1)
Status Path Size Limits
@ngxs/store(fesm2022)[gzip]
./fesm2022/*.mjs
35.06KB (+13B +0.04%) +1%

Final result: ❌

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@bundlemon
Copy link
Copy Markdown

bundlemon Bot commented Mar 20, 2026

BundleMon (NGXS Plugins)

Unchanged files (9)
Status Path Size Limits
Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin.m
js
4.1KB +0.5%
Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin.mjs
3.4KB +0.5%
Plugins(fesm2022)[gzip]
hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs
2.72KB +0.5%
Plugins(fesm2022)[gzip]
websocket-plugin/fesm2022/ngxs-websocket-plug
in.mjs
2.58KB +0.5%
Plugins(fesm2022)[gzip]
form-plugin/fesm2022/ngxs-form-plugin.mjs
2.47KB +0.5%
Plugins(fesm2022)[gzip]
devtools-plugin/fesm2022/ngxs-devtools-plugin
.mjs
2.23KB +0.5%
Plugins(fesm2022)[gzip]
logger-plugin/fesm2022/ngxs-logger-plugin.mjs
2.03KB +0.5%
Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin-i
nternals.mjs
947B +0.5%
Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin-int
ernals.mjs
453B +0.5%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
All Plugins(fesm2022)[gzip]
./-plugin/fesm2022/.mjs
20.89KB +0.5%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@bundlemon
Copy link
Copy Markdown

bundlemon Bot commented Mar 20, 2026

BundleMon (Integration Projects)

Unchanged files (1)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng21/dist-integration/browser/mai
n-(hash).js
67.22KB +1%

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@arturovt arturovt merged commit 99bd86f into master Mar 20, 2026
15 of 16 checks passed
@arturovt arturovt deleted the fix/store-unsubscribe branch March 20, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant