fix(store): skip state mutations when injector is destroyed mid-action#2406
Merged
Conversation
When the application is destroyed while an action observable is still in-flight, any subsequent setState/patchState calls on the StateContext would throw an ObjectUnsubscribedError because the underlying subjects had already completed. Guard both setState and patchState in StateContextFactory to no-op if the EnvironmentInjector has been destroyed, matching the same pattern used elsewhere in the codebase. Adds a regression test covering the case where appRef.destroy() is called during a timer-based action and setState is invoked from finalize.
arturovt
requested review from
Carniatto,
joaqcid,
kuncevic,
markwhitfeld,
poloagustin and
splincode
as code owners
|
View your CI Pipeline Execution ↗ for commit 78c2f15
☁️ Nx Cloud last updated this comment at |
@ngxs/devtools-plugin
@ngxs/form-plugin
@ngxs/hmr-plugin
@ngxs/router-plugin
@ngxs/storage-plugin
@ngxs/store
@ngxs/websocket-plugin
commit: |
BundleMonFiles updated (1)
Unchanged files (5)
Total files change +494B +0.34% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (NGXS Plugins)Unchanged files (9)
No change in files bundle size Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (Integration Projects)Files updated (1)
Total files change +14B +0.02% Final result: ✅ View report in BundleMon website ➡️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the application is destroyed while an action observable is still in-flight, any subsequent setState/patchState calls on the StateContext would throw an ObjectUnsubscribedError because the underlying subjects had already completed.
Guard both setState and patchState in StateContextFactory to no-op if the EnvironmentInjector has been destroyed, matching the same pattern used elsewhere in the codebase.
Adds a regression test covering the case where appRef.destroy() is called during a timer-based action and setState is invoked from finalize.