fix(store): warn when state is mutated after injector destruction#2407
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit aa9d366
☁️ Nx Cloud last updated this comment at |
@ngxs/devtools-plugin
@ngxs/form-plugin
@ngxs/hmr-plugin
@ngxs/router-plugin
@ngxs/storage-plugin
@ngxs/store
@ngxs/websocket-plugin
commit: |
9ee48a6 to
87617a2
Compare
patchState and setState previously silently no-oped when called after the injector was destroyed. This made it hard to diagnose unexpected silent failures, particularly in SSR scenarios where finalize() operators can run after the app has been torn down. Both methods now emit a console.warn that includes the attempted value, the state path, and a note explaining common conditions under which this can occur. The warning is gated on ngDevMode in browser builds to avoid bundle bloat, but always fires when ngServerMode is active — bundle size is not a concern on the server and silently dropped mutations are critical enough to always surface in server logs.
87617a2 to
aa9d366
Compare
BundleMonFiles updated (1)
Unchanged files (5)
Total files change +1.67KB +1.17% Groups updated (1)
Final result: ❌ View report in BundleMon website ➡️ |
BundleMon (NGXS Plugins)Unchanged files (9)
No change in files bundle size Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (Integration Projects)Unchanged files (1)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
patchState and setState previously silently no-oped when called after the
injector was destroyed. This made it hard to diagnose unexpected silent
failures, particularly in SSR scenarios where finalize() operators can
run after the app has been torn down.
Both methods now emit a console.warn that includes the attempted value,
the state path, and a note explaining common conditions under which this
can occur. The warning is gated on ngDevMode in browser builds to avoid
bundle bloat, but always fires when ngServerMode is active — bundle size
is not a concern on the server and silently dropped mutations are critical
enough to always surface in server logs.