feat(store): error in dev mode when selectSignal selector returns new reference with identical value#2441
Merged
Merged
Conversation
… reference with identical value In dev mode, `selectSignal` now logs a `console.error` when a selector returns a new object reference with the same JSON value as the previous result. This usually means the selector is missing memoization and is causing unnecessary downstream recomputations. The check uses `Object.is(a, b)` to avoid warning for properly memoized selectors that already return the same reference. The `equal` function still always returns `false` so recomputation continues to propagate normally, keeping the warning accurate for all state updates.
1d2d551 to
563ea6e
Compare
|
View your CI Pipeline Execution ↗ for commit 563ea6e
☁️ Nx Cloud last updated this comment at |
BundleMonFiles updated (1)
Unchanged files (5)
Total files change +748B +0.47% Groups updated (1)
Final result: ❌ View report in BundleMon website ➡️ |
BundleMon (NGXS Plugins)Unchanged files (9)
No change in files bundle size Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (Integration Projects)Files updated (1)
Total files change -71B -0.1% Final result: ✅ View report in BundleMon website ➡️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In dev mode,
selectSignalnow logs aconsole.errorwhen a selector returns a new object reference with the same JSON value as the previous result. This usually means the selector is missing memoization and is causing unnecessary downstream recomputations.The check uses
Object.is(a, b)to avoid warning for properly memoized selectors that already return the same reference.The
equalfunction still always returnsfalseso recomputation continues to propagate normally, keeping the warning accurate for all state updates.