Update the niscope example to have pin arrays#146
Conversation
Thanks for catching that. |
|
The pin control in .measui still only supports selection of a single pin, correct? And we don't have multi-select. So what does it look like in the UI control for default values and how do you send in multiple pin values? Do you have to type in the comma-separated strings? And does our validation logic allow that? Maybe adding a couple screenshots with the default values or showing how the user picks a different set of pins would help. |
The pin array causes an error. I posted a screenshot. |
8eda05e to
016dbe7
Compare
bkeryan
left a comment
There was a problem hiding this comment.
Approved with suggestions.
Now that this no longer affects the 12/15 drop and the corresponding C# code in https://ni.visualstudio.com/DevCentral/_git/ASW/pullrequest/407435 will be committed soon, this update is ok to me.
Also, please wait until protobuf-4.21, proto-updates-4.21, and proto-updates are committed and then commit this to main.
173cb19 to
d4bcdd3
Compare
These changes have gone in
This is no the case after the multiselect feature went in the ASW side |
What does this Pull Request accomplish?
niscope_acquire_waveformexample to have pin arrays in place of pins with comma seperated strings.Why should this Pull Request be merged?
niscope_acquire_waveformModified the name of the highlighted parameter from
trigger_sourcetoSourceWhat testing has been done?
Manually loaded the UI and verified the loading of the measurement UI and the population of pin values in the dropdown.

I ran the measurement and verified that the given values are taken properly.