Fixed #169: Removed underscore from _grpc_options#174
Merged
Conversation
bkeryan
approved these changes
Dec 16, 2022
dixonjoel
approved these changes
Dec 17, 2022
Collaborator
|
@tkrebes Why is this a draft? I'm marking it "Ready for review" so we can merge it. |
bkeryan
requested review from
csjall,
jonlugoatx,
mshafer-NI and
nstokes-nati
as code owners
Collaborator
I will also test it. |
bkeryan
requested changes
Dec 19, 2022
bkeryan
requested changes
Dec 19, 2022
bkeryan
approved these changes
Dec 19, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Removes underscore from _grpc_options parameter passed to nimi-python Session constructors.
Updates examples to use 1.4.3 or later versions of nimi-python APIs.
Fixes
NISwitchControlRelays.seq, which had the wrong setting forUse adapter settings for Python interpreter.Why should this Pull Request be merged?
For the 1.4.3 release of nimi-python, Session constructors currently take a grpc_options parameter: #169
What testing has been done?
Manually tested with MeasurementLink 23.0.0d719: