Update package minor version and protobuf dependency - #371
Merged
Conversation
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
mjohanse-emr
requested review from
bkeryan,
dixonjoel and
jfriedri-ni
as code owners
August 4, 2026 21:07
Contributor
bkeryan
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
ni.measurements.data.v1.protopackage since we've added new float waveform types.ni-protobuf-typesdependency to>=1.3.0.dev0which is the version we just published that contains the new float waveform types. The generated code in this package will require this updated version ofni-protobuf-typeswhen consumed byni.measurements.data.v1.client.Why should this Pull Request be merged?
AB#3985023
AB#3985045
We want to pass these new float waveform types up the ni-apis-python dependency chain to be consumed by
ni.measurements.data.v1.client1.What testing has been done?
PR checks.