Fix tests that need 32 DIO lines incorrectly using device with less than 32 DIO lines - #999
Merged
Merged
Conversation
zhindes
approved these changes
Aug 3, 2026
Collaborator
|
@EnYi-ni - the build failure looked unrelated... clicked re-run |
bkeryan
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contribution adheres to CONTRIBUTING.md.
[ ] I've updated CHANGELOG.md if applicable.[ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Add a fixture for DO to use only X series device with >= 32 DIO lines
Update the currently failing tests that need 32 lines to use the above fixture.
Why should this Pull Request be merged?
AB#3978397
To handle testing in a setup where there is a X series device with < 32 DIO lines.
What testing has been done?
Tested on a controller setup with PXIe-6375 and PXIe-6363. Place PXIe-6375 in a slot ahead of PXIe-6363. This is so that PXIe-6375 is chosen as the first possible X series device if there is no requirement of 32 DIO lines. No failure is observed when running pytest.
Tested on a controller with PXIe-6363 only. No failure is observed when running pytest.