Skip to content

nirfsg: Synchronize API updates with latest driver - #2188

Merged
vnktshr21 merged 3 commits into
ni:masterfrom
mohit-emerson:release_latest_rfsg
Jul 28, 2026
Merged

nirfsg: Synchronize API updates with latest driver#2188
vnktshr21 merged 3 commits into
ni:masterfrom
mohit-emerson:release_latest_rfsg

Conversation

@mohit-emerson

@mohit-emerson mohit-emerson commented Jul 28, 2026

Copy link
Copy Markdown
Contributor
  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
    -[ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • This PR synchronizes with latest API updates done for nirfsg.

  • AMPLITUDE_FLATNESS and AMPLITUDE_AND_PHASE_FLATNESS added to enum DeembeddingType.

List issues fixed by this Pull Request below, if any.

What testing has been done?

  • A successful tox execution.
  • PR Validations

@codecov-commenter

codecov-commenter commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.32%. Comparing base (c821673) to head (ffe5b58).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2188   +/-   ##
=======================================
  Coverage   89.32%   89.32%           
=======================================
  Files          73       73           
  Lines       19048    19048           
=======================================
+ Hits        17014    17015    +1     
+ Misses       2034     2033    -1     
Flag Coverage Δ
codegenunittests 84.90% <ø> (ø)
nidcpowersystemtests 94.38% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.02% <ø> (ø)
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests 92.29% <ø> (ø)
nifakeunittests 86.01% <ø> (ø)
nifgensystemtests 94.32% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsgsystemtests 81.12% <ø> (ø)
niscopesystemtests 89.96% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 81.56% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
generated/nirfsg/nirfsg/session.py 90.01% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c821673...ffe5b58. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread CHANGELOG.md
@mohit-emerson
mohit-emerson marked this pull request as ready for review July 28, 2026 09:28

@vnktshr21 vnktshr21 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update description to include point on re-ordering and version changes resulting from internal metadata

@vnktshr21
vnktshr21 merged commit b7c2d11 into ni:master Jul 28, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants