workflow: Add unit tests and reporting results workflows by zoechanzy · Pull Request #64 · ni/nislsc-python

zoechanzy · 2026-07-21T05:19:28Z

What does this Pull Request accomplish?

Update CI workflow to run unit tests and report results
Create run_unit_tests workflow
Create report_test_results workflow to report test results
Add check_workflows.yml
Update to poetry 2.4.1

Why should this Pull Request be merged?

Add unit tests and reporting result github workflows.

Related work item:
https://dev.azure.com/ni/DevCentral/_workitems/edit/3776265

Address #51

ni-github-admins · 2026-07-21T05:19:43Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Code Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copilot

Pull request overview

This PR introduces reusable GitHub Actions workflows to run unit tests across multiple OS/Python versions and to publish aggregated JUnit results back to GitHub checks/PRs, then wires those workflows into the main CI workflow.

Changes:

Added run_unit_tests.yml reusable workflow to execute pytest (with coverage) and upload JUnit XML artifacts.
Added report_test_results.yml reusable workflow to download those artifacts and publish results via publish-unit-test-result-action.
Updated CI.yml to invoke unit tests and test reporting.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
.github/workflows/run_unit_tests.yml	New reusable workflow to run pytest across a matrix and upload JUnit XML artifacts.
.github/workflows/report_test_results.yml	New reusable workflow to download artifacts and publish unit test results to GitHub.
.github/workflows/CI.yml	Enables the new unit test + reporting workflows as part of CI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-07-21T06:01:16Z

Test Results

14 files 14 suites 16m 3s ⏱️
224 tests 224 ✅ 0 💤 0 ❌
3 136 runs 3 136 ✅ 0 💤 0 ❌

Results for commit 586ea76.

♻️ This comment has been updated with latest results.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

.github/workflows/CI.yml:40

Indentation under report_test_results: is inconsistent with the rest of the workflow. Normalizing it to the same indentation style as other jobs reduces the risk of accidental YAML structure mistakes during future edits.

  report_test_results:
     name: Report test results
     uses: ./.github/workflows/report_test_results.yml
     needs: [run_unit_tests]
     if: always()

* Update CI workflow to run unit tests and report results * Create run_unit_tests workflow to run on Windows and Ubuntu * Create report_test_results workflow to report test results --------- Signed-off-by: zoechanzy <zoe.chan@emerson.com>

* Remove test_installdriver step from run_unit_tests.yml workflow * The nislsc package doesn't have it. --------- Signed-off-by: zoechanzy <zoe.chan@emerson.com>

* Update run_unit_tests.yml to include Python 3.14 in the test matrix. --------- Signed-off-by: zoechanzy <zoe.chan@emerson.com>

* Add check_workflows.yml to CI and PR workflows * Add check_succeeded job to CI workflow * Add permissions to check_workflows.yml, CI.yml, and PR.yml --------- Signed-off-by: zoechanzy <zoe.chan@emerson.com>

* Disable advanced security for Run zizmor * Remove security-events: write of check_workflows.yml --------- Signed-off-by: zoechanzy <zoe.chan@emerson.com>

… in zizmor * Added content: read permissions CI workflow. * Added permission: {} to checks succeeded job in CI workflow. * Added permission: {} in sync_github_issues_to_azdo workflow. * Added content: read permissions to build, publish, check_docs and run_unit_tests workflows. * Added persis-credentials: false to checkout action --------- Signed-off-by: zoechanzy <zoe.chan@emerson.com>

* Remove permissions: contents: read from build.yml, check_docs.yml, publish.yml and run_unit_tests.yml --------- Signed-off-by: zoechanzy <zoe.chan@emerson.com>

*This reverts commit 1e5cf35. --------- Signed-off-by: zoechanzy <zoe.chan@emerson.com>

tjying95

Good after address feedback and fix action failure for Python > 3.9.

* Added typing-extensions to pyproject.toml * Updated poetry.lock using poetry lock --------- Signed-off-by: zoechanzy <zoe.chan@emerson.com>

* Set min-release-age to 2 weeks in poetry.toml * Regenerate poetry.lock file after updating poetry version to 2.4.1 --------- Signed-off-by: zoechanzy <zoe.chan@emerson.com>

bkeryan

Approved with suggestions

* Use split Poetry markers so Python 3.10 stays on pytest 8 --------- Signed-off-by: zoechanzy <zoe.chan@emerson.com>

zoechanzy requested a review from Copilot July 21, 2026 05:33

Copilot started reviewing on behalf of zoechanzy July 21, 2026 05:34 View session

Copilot AI reviewed Jul 21, 2026

View reviewed changes

Comment thread .github/workflows/run_unit_tests.yml Outdated

Comment thread .github/workflows/run_unit_tests.yml Outdated

Comment thread .github/workflows/run_unit_tests.yml

Comment thread .github/workflows/CI.yml Outdated

zoechanzy force-pushed the users/zchan/nislsc_github_workflows branch 2 times, most recently from 3485d49 to 059cebc Compare July 21, 2026 05:58

zoechanzy force-pushed the users/zchan/nislsc_github_workflows branch from 059cebc to c6e5870 Compare July 21, 2026 06:27

tjying95 mentioned this pull request Jul 22, 2026

unit test: Introduce python test for nislsc modules #63

Merged

bkeryan requested changes Jul 22, 2026

View reviewed changes

Comment thread .github/workflows/run_unit_tests.yml Outdated

Comment thread .github/workflows/run_unit_tests.yml Outdated

Comment thread .github/workflows/run_unit_tests.yml

Comment thread .github/workflows/CI.yml

zoechanzy requested a review from Copilot July 27, 2026 01:08

Copilot started reviewing on behalf of zoechanzy July 27, 2026 01:08 View session

Copilot AI reviewed Jul 27, 2026

View reviewed changes

Comment thread .github/workflows/run_unit_tests.yml

Comment thread .github/workflows/CI.yml Outdated

Comment thread .github/workflows/PR.yml Outdated

zoechanzy force-pushed the users/zchan/nislsc_github_workflows branch from 8717476 to d91112d Compare July 27, 2026 01:29

zoechanzy added 3 commits July 27, 2026 09:46

workflow: Remove test_installdriver step

0eafbe9

* Remove test_installdriver step from run_unit_tests.yml workflow * The nislsc package doesn't have it. --------- Signed-off-by: zoechanzy <zoe.chan@emerson.com>

workflow: Update supported Python versions

94ececd

* Update run_unit_tests.yml to include Python 3.14 in the test matrix. --------- Signed-off-by: zoechanzy <zoe.chan@emerson.com>

zoechanzy force-pushed the users/zchan/nislsc_github_workflows branch 3 times, most recently from 6059bbf to 1ebc733 Compare July 27, 2026 04:53

workflow: Add check_workflows.yml

ff769c2

* Add check_workflows.yml to CI and PR workflows * Add check_succeeded job to CI workflow * Add permissions to check_workflows.yml, CI.yml, and PR.yml --------- Signed-off-by: zoechanzy <zoe.chan@emerson.com>

zoechanzy force-pushed the users/zchan/nislsc_github_workflows branch from 1ebc733 to ff769c2 Compare July 27, 2026 04:55

zoechanzy marked this pull request as ready for review July 28, 2026 00:24

zoechanzy requested review from kkang-NI and tjying95 as code owners July 28, 2026 00:24

bkeryan reviewed Jul 30, 2026

View reviewed changes

Comment thread .github/workflows/CI.yml

zoechanzy added 2 commits July 30, 2026 13:05

workflow: Disable advanced security

84d5bd2

* Disable advanced security for Run zizmor * Remove security-events: write of check_workflows.yml --------- Signed-off-by: zoechanzy <zoe.chan@emerson.com>

zoechanzy force-pushed the users/zchan/nislsc_github_workflows branch from 9203d11 to d26ff09 Compare July 30, 2026 05:19

workflow: Added permissions to CI.yml only

1e5cf35

* Remove permissions: contents: read from build.yml, check_docs.yml, publish.yml and run_unit_tests.yml --------- Signed-off-by: zoechanzy <zoe.chan@emerson.com>

Revert "workflow: Added permissions to CI.yml only"

67eb5ba

*This reverts commit 1e5cf35. --------- Signed-off-by: zoechanzy <zoe.chan@emerson.com>

zoechanzy force-pushed the users/zchan/nislsc_github_workflows branch from 8b92bab to 67eb5ba Compare July 30, 2026 05:48

tjying95 approved these changes Jul 30, 2026

View reviewed changes

workflow: Update pyproject.toml

6a646e5

* Added typing-extensions to pyproject.toml * Updated poetry.lock using poetry lock --------- Signed-off-by: zoechanzy <zoe.chan@emerson.com>

Copilot started work on behalf of zoechanzy July 30, 2026 10:16 View session

Copilot finished work on behalf of zoechanzy July 30, 2026 10:43

zoechanzy closed this Jul 30, 2026

zoechanzy reopened this Jul 30, 2026

bkeryan reviewed Jul 30, 2026

View reviewed changes

Comment thread .github/workflows/run_unit_tests.yml

bkeryan reviewed Jul 30, 2026

View reviewed changes

Comment thread poetry.lock

workflow: Update to poetry 2.4.1

78c7878

* Set min-release-age to 2 weeks in poetry.toml * Regenerate poetry.lock file after updating poetry version to 2.4.1 --------- Signed-off-by: zoechanzy <zoe.chan@emerson.com>

zoechanzy requested a review from bkeryan August 3, 2026 01:38

bkeryan approved these changes Aug 3, 2026

View reviewed changes

Comment thread pyproject.toml

workflow: pin pytest <9 on Python <3.11

586ea76

* Use split Poetry markers so Python 3.10 stays on pytest 8 --------- Signed-off-by: zoechanzy <zoe.chan@emerson.com>

zoechanzy force-pushed the users/zchan/nislsc_github_workflows branch from 0f280a1 to 586ea76 Compare August 4, 2026 00:30

kkang-NI approved these changes Aug 4, 2026

View reviewed changes

zoechanzy merged commit e977eda into main Aug 4, 2026
21 checks passed

tjying95 mentioned this pull request Aug 5, 2026

Add unit tests #51

Closed

Uh oh!

Conversation

zoechanzy commented Jul 21, 2026 • edited by tjying95 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this Pull Request accomplish?

Why should this Pull Request be merged?

Uh oh!

ni-github-admins commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tjying95 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bkeryan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

zoechanzy commented Jul 21, 2026 •

edited by tjying95

Loading

ni-github-admins commented Jul 21, 2026 •

edited

Loading

github-actions Bot commented Jul 21, 2026 •

edited

Loading