Add function to return session handle from nisync #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wchung <wai.kin.chung@ni.com>
wchung-ni
requested review from
CHrislian-NI,
tkrebes and
tsengguanyung
as code owners
Collaborator
Author
|
@sjasonsmith could you review on this new add function ? |
CHrislian-NI
approved these changes
Nov 12, 2024
tkrebes
approved these changes
Nov 12, 2024
sjasonsmith
suggested changes
Nov 12, 2024
ni-jfitzger
reviewed
Nov 12, 2024
Signed-off-by: wchung <wai.kin.chung@ni.com>
Signed-off-by: wchung <wai.kin.chung@ni.com>
Signed-off-by: wchung <wai.kin.chung@ni.com>
tsengguanyung
approved these changes
Nov 13, 2024
sjasonsmith
reviewed
Nov 13, 2024
sjasonsmith
approved these changes
Nov 13, 2024
ni-jfitzger
approved these changes
Nov 13, 2024
CHrislian-NI
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wchung wai.kin.chung@ni.com
What does this Pull Request accomplish?
Add a function that return read-only session handle.
Why should this Pull Request be merged?
Existing function that returning session object cannot fulfill NI-Digital use case.
What testing has been done?
PR Build
[manual pytest]