fix(gamepad): 接続完了時の通常入力準備を保証 - #150
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
接続APIの正常終了を、選択した送信方式の通常入力経路が接続初期化中のautomatic input holdoffに遮られていない時点へ変更します。
Periodicは最新replyのholdoff終了後にReportLoopを開始してから成功を公開し、Directは明示入力がholdoff対象外であるためprotocol readyで同じ公開契約を満たします。
Related
spec/complete/unit_086/NORMAL_INPUT_READINESS.mdspec/initial/api.mdspec/initial/lifecycle.mdspec/initial/testing.mdChanges
ReportSenderに、readiness公開前に受理された最新replyのholdoff期限まで待つ処理を追加ControllerRuntimeでprotocol readyとinput readyを分離し、PeriodicはReportLoop開始後、Directはprotocol ready直後に接続成功を公開input_readyとstage=input_readinessを追加Commit Log
8217929 fix(gamepad): 接続完了時の通常入力準備を保証Testing
uv run ruff format --check .— pass(106 files already formatted)uv run ruff check .— passuv run ty check --no-progress— passuv run pytest tests/unit— pass(450 passed)uv run pytest tests/integration— pass(165 passed)uv run --group docs mkdocs build --strict— passuv run pytest --collect-only tests/hardware/test_reply_holdoff.py -q— pass(10 tests collected)Hardware
usb:0、CSR8510 A10(VID:PID0A12:0001)、WinUSB/libwdi、Bumble 0.0.233でfresh Pairを実行protocol_readyからinput_readyへ進み、接続完了直後の50 ms窓でButton A付き周期0x30を7件、後続neutral、L2CAP切断、adapter解放を確認inputとして数えたtest bugにより1 failed in 5.58s。実際の送信理由はperiodicで、harnessを修正済みReview Notes
docs-quality-reviewで公開契約、非保証、実機確認範囲を照合。未解決のmust-fixなし