Javascript 1#1
Open
nick-brett wants to merge 5 commits into
Open
Conversation
Blevs
reviewed
Jun 11, 2019
| // }; | ||
| // myFunction(); | ||
|
|
||
| let myFunction = () => "Function was invoked"; //<---- which is correct? |
Collaborator
There was a problem hiding this comment.
They wanted let myFunction = () => console.log("Function was invoked"), but that is honestly close enough that I can see you know what you are doing.
Blevs
reviewed
Jun 11, 2019
| // }); | ||
| // console.log(triple); No newline at end of file | ||
| // console.log(triple); | ||
| // ??? const triple = exampleArray.map(num) => num * 3; ?????????? No newline at end of file |
Collaborator
There was a problem hiding this comment.
Really close. Map takes the callback, which you wrote perfectly, as an argument. It would be const triple = exampleArray.map((num) => num * 3);
Collaborator
|
I am not going to merge this yet, because if you have time today I would like to see you go back and finish a bit more. If not, no big deal, but it is important to get the practice in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is what I have so far for the JS-I assignment.